[Asterisk-code-review] res_aeap & res_speech_aeap: Add Asterisk External Application Protocol (asterisk[master])

[Kevin Harwell]

Attention is currently required from: Joshua Colp.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17330 )

Change subject: res_aeap & res_speech_aeap: Add Asterisk External Application Protocol
......................................................................


Patch Set 3:

(5 comments)

File include/asterisk/res_aeap.h:

https://gerrit.asterisk.org/c/asterisk/+/17330/comment/0a9a96b8_aaba8f9a 
PS3, Line 33: 
> Did we? I didn't get that memo. […]
http://lists.digium.com/pipermail/asterisk-dev/2022-January/078527.html

I'll leave this open while we await feedback.


https://gerrit.asterisk.org/c/asterisk/+/17330/comment/b42e7827_cf13c114 
PS3, Line 252: int ast_aeap_disconnect(struct ast_aeap *aeap);
> I'd document that it may block, then.
Done


File res/res_aeap.c:

https://gerrit.asterisk.org/c/asterisk/+/17330/comment/ad596786_3813eaa0 
PS3, Line 35: 			<configObject name="server">
> We're probably doomed either way. :D It can stay as you have it.
Ack


File res/res_aeap/transaction.c:

https://gerrit.asterisk.org/c/asterisk/+/17330/comment/349452e5_3a6d5af6 
PS3, Line 245: 	if (!ao2_link(transactions, tsx)) {
> This creates a circular reference, how is it broken/taken care of/not applicable?
After looking at the code there is no reason for the added reference, so I removed it, and also ensured all transactions are ended before the container itself gets unref'd.


File res/res_speech_aeap.c:

https://gerrit.asterisk.org/c/asterisk/+/17330/comment/c289476e_d8d30387 
PS3, Line 495: 	speech_engine_create_and_register(ast_sorcery_object_get_id(obj), NULL,
> Ah. […]
I suppose kinda. Will fix.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17330
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iaa4b259f84aa63501e5fd2a6fb107f900b4d4ed2
Gerrit-Change-Number: 17330
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 13 Jan 2022 22:28:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220113/2dc91164/attachment.html>