<p> Attention is currently required from: Joshua Colp. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/17330">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">File include/asterisk/res_aeap.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17330/comment/0a9a96b8_aaba8f9a">Patch Set #3, Line 33:</a> <code style="font-family:monospace,monospace"></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Did we? I didn't get that memo. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">http://lists.digium.com/pipermail/asterisk-dev/2022-January/078527.html</p><p style="white-space: pre-wrap; word-wrap: break-word;">I'll leave this open while we await feedback.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17330/comment/b42e7827_cf13c114">Patch Set #3, Line 252:</a> <code style="font-family:monospace,monospace">int ast_aeap_disconnect(struct ast_aeap *aeap);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I'd document that it may block, then.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_aeap.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17330/comment/ad596786_3813eaa0">Patch Set #3, Line 35:</a> <code style="font-family:monospace,monospace"> <configObject name="server"></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">We're probably doomed either way. :D It can stay as you have it.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Ack</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_aeap/transaction.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17330/comment/349452e5_3a6d5af6">Patch Set #3, Line 245:</a> <code style="font-family:monospace,monospace"> if (!ao2_link(transactions, tsx)) {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This creates a circular reference, how is it broken/taken care of/not applicable?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">After looking at the code there is no reason for the added reference, so I removed it, and also ensured all transactions are ended before the container itself gets unref'd.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="null">File res/res_speech_aeap.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17330/comment/c289476e_d8d30387">Patch Set #3, Line 495:</a> <code style="font-family:monospace,monospace"> speech_engine_create_and_register(ast_sorcery_object_get_id(obj), NULL,</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Ah. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I suppose kinda. Will fix.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/17330">change 17330</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/17330"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iaa4b259f84aa63501e5fd2a6fb107f900b4d4ed2 </div>
<div style="display:none"> Gerrit-Change-Number: 17330 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 13 Jan 2022 22:28:34 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Comment-In-Reply-To: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>