[Asterisk-code-review] res_aeap & res_speech_aeap: Add Asterisk External Application Protocol (asterisk[master])

[Joshua Colp]

Attention is currently required from: Kevin Harwell.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17330 )

Change subject: res_aeap & res_speech_aeap: Add Asterisk External Application Protocol
......................................................................


Patch Set 3:

(4 comments)

File include/asterisk/res_aeap.h:

https://gerrit.asterisk.org/c/asterisk/+/17330/comment/e147fc0a_6f790f27 
PS3, Line 33: 
> The file itself or each function definition? Also, I thought we quit adding \since to things.
Did we? I didn't get that memo. And function definitions is what I was referring to, but if we've stopped then shrug.


https://gerrit.asterisk.org/c/asterisk/+/17330/comment/82406308_9e93214f 
PS3, Line 252: int ast_aeap_disconnect(struct ast_aeap *aeap);
> Maybe. Depends on how the underlying transport handles it.
I'd document that it may block, then.


File res/res_aeap.c:

https://gerrit.asterisk.org/c/asterisk/+/17330/comment/96d9ff35_bc49b1e6 
PS3, Line 35: 			<configObject name="server">
> Ah yeah heh I debated this a bit. […]
We're probably doomed either way. :D It can stay as you have it.


File res/res_speech_aeap.c:

https://gerrit.asterisk.org/c/asterisk/+/17330/comment/7986e277_2758b536 
PS3, Line 495: 	speech_engine_create_and_register(ast_sorcery_object_get_id(obj), NULL,
> Not sure what ya mean here? NULL is passed in for it, so yes it will always be NULL here. […]
Ah. Is it a test detail leaking into the public interface?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17330
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Iaa4b259f84aa63501e5fd2a6fb107f900b4d4ed2
Gerrit-Change-Number: 17330
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 12 Jan 2022 23:14:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220112/df3107d9/attachment.html>