[Asterisk-code-review] Add support for delayed shutdown of Asterisk when checking f... (testsuite[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/6845 )

Change subject: Add support for delayed shutdown of Asterisk when checking for leaks.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/6845/2/lib/python/asterisk/asterisk.py
File lib/python/asterisk/asterisk.py:

https://gerrit.asterisk.org/#/c/6845/2/lib/python/asterisk/asterisk.py@659
PS2, Line 659:             reactor.callLater(delay, __actual_stop)
> How can/should we deal with if delay exceeds reactor timeout?  Likely rare 
I think it would be okay to automatically bump up the reactor-timeout if memcheck-delay-stop is set and greater that the timeout. For instance:

if memcheck_delay_stop > reactor_timeout:
  reactor_timeout = memcheck_delay_stop + 3

That way someone doesn't have to remember to set both. If that's an easy thing to do. Not sure off the top of my head where reactor_timeout gets set.



-- 
To view, visit https://gerrit.asterisk.org/6845
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67ec89e4a116526ad34796a233e15fec794cf3e1
Gerrit-Change-Number: 6845
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 25 Oct 2017 16:32:14 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171025/2843eaf3/attachment.html>