<p>Kevin Harwell <strong>posted comments</strong> on this change.</p><p><a href="https://gerrit.asterisk.org/6845">View Change</a></p><p>Patch set 2:</p><p>(1 comment)</p><ul style="list-style: none; padding-left: 20px;"><li><p><a href="https://gerrit.asterisk.org/#/c/6845/2/lib/python/asterisk/asterisk.py">File lib/python/asterisk/asterisk.py:</a></p><ul style="list-style: none; padding-left: 20px;"><li><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/6845/2/lib/python/asterisk/asterisk.py@659">Patch Set #2, Line 659:</a> <code style="font-family:monospace,monospace">            reactor.callLater(delay, __actual_stop)</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">How can/should we deal with if delay exceeds reactor timeout?  Likely rare </blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think it would be okay to automatically bump up the reactor-timeout if memcheck-delay-stop is set and greater that the timeout. For instance:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">if memcheck_delay_stop > reactor_timeout:<br>  reactor_timeout = memcheck_delay_stop + 3</pre><p style="white-space: pre-wrap; word-wrap: break-word;">That way someone doesn't have to remember to set both. If that's an easy thing to do. Not sure off the top of my head where reactor_timeout gets set.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/6845">change 6845</a>. To unsubscribe, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/6845"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I67ec89e4a116526ad34796a233e15fec794cf3e1 </div>
<div style="display:none"> Gerrit-Change-Number: 6845 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins2 </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 25 Oct 2017 16:32:14 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>