[Asterisk-code-review] Add support for delayed shutdown of Asterisk when checking f... (testsuite[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/6845 )

Change subject: Add support for delayed shutdown of Asterisk when checking for leaks.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/6845/2/lib/python/asterisk/asterisk.py
File lib/python/asterisk/asterisk.py:

https://gerrit.asterisk.org/#/c/6845/2/lib/python/asterisk/asterisk.py@659
PS2, Line 659:             reactor.callLater(delay, __actual_stop)
> I think it would be okay to automatically bump up the reactor-timeout if me
Reactor timeout is set when the test is initialized, and we don't know if memcheck_delay_stop is actually active until after Asterisk instances are running (refs file exists).

I think we could unconditionally bump reactor_timeout if memcheck_delay_stop is set & higher.  So if memcheck_delay_stop is set to 90 seconds that would increase the reactor timeout even if REF_DEBUG / valgrind are not active.  Any complaints about this?



-- 
To view, visit https://gerrit.asterisk.org/6845
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67ec89e4a116526ad34796a233e15fec794cf3e1
Gerrit-Change-Number: 6845
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 25 Oct 2017 16:47:01 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171025/e5daef48/attachment.html>