[Asterisk-code-review] Add support for delayed shutdown of Asterisk when checking f... (testsuite[master])

Corey Farrell asteriskteam at digium.com
Fri Oct 20 09:42:07 CDT 2017


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/6845 )

Change subject: Add support for delayed shutdown of Asterisk when checking for leaks.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/6845/2/lib/python/asterisk/asterisk.py
File lib/python/asterisk/asterisk.py:

https://gerrit.asterisk.org/#/c/6845/2/lib/python/asterisk/asterisk.py@659
PS2, Line 659:             reactor.callLater(delay, __actual_stop)
How can/should we deal with if delay exceeds reactor timeout?  Likely rare but might be needed for a couple tests dealing with min_se=90.  Would test-config.yaml just need to ensure reactor-timeout >= memcheck-delay-stop?



-- 
To view, visit https://gerrit.asterisk.org/6845
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67ec89e4a116526ad34796a233e15fec794cf3e1
Gerrit-Change-Number: 6845
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Fri, 20 Oct 2017 14:42:07 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20171020/2eab1cc9/attachment.html>


More information about the asterisk-code-review mailing list