[asterisk-dev] [Code Review] 2867: Convert and update the local channel t38 queryoption test

[opticron]

> On Sept. 23, 2013, 9:15 a.m., Matt Jordan wrote:
> > asterisk/trunk/tests/fax/local_channel_t38_queryoption/configs/ast1/extensions.conf, line 5
> > <https://reviewboard.asterisk.org/r/2867/diff/2/?file=46063#file46063line5>
> >
> >     I am a bit curious why this event is needed, since the fax stack should send a successful SendFAX event.
> >     
> >     https://wiki.asterisk.org/wiki/display/AST/Asterisk+12+ManagerEvent_SendFAX

It is unlikely that a SendFAX or ReceiveFAX event will be sent if there's an error during setup given the code paths in res_fax.c. Most code paths set the status variables on the channel, print a message and return. There is always the reactor timeout, but I'd prefer the test to bail ASAP.


> On Sept. 23, 2013, 9:15 a.m., Matt Jordan wrote:
> > asterisk/trunk/tests/fax/local_channel_t38_queryoption/configs/ast2/extensions.conf, line 5
> > <https://reviewboard.asterisk.org/r/2867/diff/2/?file=46065#file46065line5>
> >
> >     And this one should get a ReceiveFAX event.

See comments above.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2867/#review9760
-----------------------------------------------------------


On Sept. 18, 2013, 9:02 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2867/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2013, 9:02 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22318
>     https://issues.asterisk.org/jira/browse/ASTERISK-22318
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This converts the local channel t38 queryoption test from lua to python and gets it working again on 11, 12, and trunk. The cause of the failures was not in the test itself and is addressed in https://reviewboard.asterisk.org/r/2866/.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/fax/local_channel_t38_queryoption/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/fax/local_channel_t38_queryoption/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/fax/local_channel_t38_queryoption/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/fax/local_channel_t38_queryoption/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/fax/local_channel_t38_queryoption/run-test 4192 
>   asterisk/trunk/tests/fax/local_channel_t38_queryoption/test.lua 4192 
> 
> Diff: https://reviewboard.asterisk.org/r/2867/diff/
> 
> 
> Testing
> -------
> 
> Ran against 1.8, 11, 12, and trunk and verified expected behaviors.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130923/168d39aa/attachment.htm>