[asterisk-dev] [Code Review] 2867: Convert and update the local channel t38 queryoption test

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2867/#review9760
-----------------------------------------------------------



asterisk/trunk/tests/fax/local_channel_t38_queryoption/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/2867/#comment18952>

    I am a bit curious why this event is needed, since the fax stack should send a successful SendFAX event.
    
    https://wiki.asterisk.org/wiki/display/AST/Asterisk+12+ManagerEvent_SendFAX



asterisk/trunk/tests/fax/local_channel_t38_queryoption/configs/ast2/extensions.conf
<https://reviewboard.asterisk.org/r/2867/#comment18953>

    And this one should get a ReceiveFAX event.



asterisk/trunk/tests/fax/local_channel_t38_queryoption/run-test
<https://reviewboard.asterisk.org/r/2867/#comment18950>

    pep8 pickiness: values for parameters passed to a function should not have spaces between the parameter and the value.
    
    channel="sip/1234 at fax", exten="1234", etc.



asterisk/trunk/tests/fax/local_channel_t38_queryoption/run-test
<https://reviewboard.asterisk.org/r/2867/#comment18951>

    I'd recommend adding some post-test verification.
    
    For example, check the value of success_received - if not 2, log an error that not all UserEvent/FaxStatus events were received.
    
    We should always have something indicating what all didn't happen in a test when it fails.


- Matt Jordan


On Sept. 18, 2013, 2:02 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2867/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2013, 2:02 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22318
>     https://issues.asterisk.org/jira/browse/ASTERISK-22318
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This converts the local channel t38 queryoption test from lua to python and gets it working again on 11, 12, and trunk. The cause of the failures was not in the test itself and is addressed in https://reviewboard.asterisk.org/r/2866/.
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/tests/fax/local_channel_t38_queryoption/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/fax/local_channel_t38_queryoption/configs/ast1/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/fax/local_channel_t38_queryoption/configs/ast2/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/fax/local_channel_t38_queryoption/configs/ast2/sip.conf PRE-CREATION 
>   asterisk/trunk/tests/fax/local_channel_t38_queryoption/run-test 4192 
>   asterisk/trunk/tests/fax/local_channel_t38_queryoption/test.lua 4192 
> 
> Diff: https://reviewboard.asterisk.org/r/2867/diff/
> 
> 
> Testing
> -------
> 
> Ran against 1.8, 11, 12, and trunk and verified expected behaviors.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130923/7d4218cb/attachment.htm>