[asterisk-dev] [Code Review] 3086: pjsip.conf.sample update: improve documentation of pjsip endpoints behind NAT and update for snake case change

[rnewton]

> On Dec. 20, 2013, 1:56 a.m., Matt Jordan wrote:
> > branches/12/configs/pjsip.conf.sample, line 435
> > <https://reviewboard.asterisk.org/r/3086/diff/1/?file=49880#file49880line435>
> >
> >     May as well align the comment with the others

Everything in that section is generated by my script, I adjusted this line manually, but I'll poke the script to see if we can get the comment alignment better later on.


- rnewton


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3086/#review10469
-----------------------------------------------------------


On Dec. 20, 2013, 12:18 a.m., rnewton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3086/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2013, 12:18 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23004
>     https://issues.asterisk.org/jira/browse/ASTERISK-23004
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Added another NAT example to pjsip.conf.sample. We had a few mentions of NAT configuration throughout the sample, but I added another for a little bit more clarity.
> 
> Additionally many pjsip options were affected by the change to snake case, so I fixed any instances of those options in pjsip.conf.
> 
> I regenerated the config option list (at the bottom of the file) from a new xml config doc dump, so all the snake case changes should be reflected there, as well as any other changes to those options.
> 
> 
> Diffs
> -----
> 
>   branches/12/configs/pjsip.conf.sample 404396 
> 
> Diff: https://reviewboard.asterisk.org/r/3086/diff/
> 
> 
> Testing
> -------
> 
> Only documentation outside of source code, doesn't appear to break anything.
> 
> 
> Thanks,
> 
> rnewton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131220/6de340bb/attachment.html>