[asterisk-dev] [Code Review] 3086: pjsip.conf.sample update: improve documentation of pjsip endpoints behind NAT and update for snake case change

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3086/#review10469
-----------------------------------------------------------



branches/12/configs/pjsip.conf.sample
<https://reviewboard.asterisk.org/r/3086/#comment19933>

    Blobs



branches/12/configs/pjsip.conf.sample
<https://reviewboard.asterisk.org/r/3086/#comment19934>

    This last sentence is a bit awkward.
    
    I'd phrase it as:
    
    The most important settings to configure are:
     * direct_media, to ensure that Asterisk stays in the media patch
     * rtp_symmetric and force_rport, to help  the far-end firewall/NAT device
    
    Something along those lines.



branches/12/configs/pjsip.conf.sample
<https://reviewboard.asterisk.org/r/3086/#comment19936>

    lower case 'F': Firewall/firewall



branches/12/configs/pjsip.conf.sample
<https://reviewboard.asterisk.org/r/3086/#comment19935>

    are behind _a_ NAT/firewall



branches/12/configs/pjsip.conf.sample
<https://reviewboard.asterisk.org/r/3086/#comment19937>

    I'd link to the specific page. We don't change the names of wiki pages in order to main external links.



branches/12/configs/pjsip.conf.sample
<https://reviewboard.asterisk.org/r/3086/#comment19938>

    May as well align the comment with the others


- Matt Jordan


On Dec. 19, 2013, 6:18 p.m., rnewton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3086/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2013, 6:18 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-23004
>     https://issues.asterisk.org/jira/browse/ASTERISK-23004
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Added another NAT example to pjsip.conf.sample. We had a few mentions of NAT configuration throughout the sample, but I added another for a little bit more clarity.
> 
> Additionally many pjsip options were affected by the change to snake case, so I fixed any instances of those options in pjsip.conf.
> 
> I regenerated the config option list (at the bottom of the file) from a new xml config doc dump, so all the snake case changes should be reflected there, as well as any other changes to those options.
> 
> 
> Diffs
> -----
> 
>   branches/12/configs/pjsip.conf.sample 404396 
> 
> Diff: https://reviewboard.asterisk.org/r/3086/diff/
> 
> 
> Testing
> -------
> 
> Only documentation outside of source code, doesn't appear to break anything.
> 
> 
> Thanks,
> 
> rnewton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131220/446eb078/attachment.html>