[asterisk-dev] [Code Review] 3086: pjsip.conf.sample update: improve documentation of pjsip endpoints behind NAT and update for snake case change

rnewton reviewboard at asterisk.org
Fri Dec 20 09:28:37 CST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3086/
-----------------------------------------------------------

(Updated Dec. 20, 2013, 3:28 p.m.)


Review request for Asterisk Developers.


Changes
-------

Updated diff after fixing Matt's findings.


Bugs: ASTERISK-23004
    https://issues.asterisk.org/jira/browse/ASTERISK-23004


Repository: Asterisk


Description
-------

Added another NAT example to pjsip.conf.sample. We had a few mentions of NAT configuration throughout the sample, but I added another for a little bit more clarity.

Additionally many pjsip options were affected by the change to snake case, so I fixed any instances of those options in pjsip.conf.

I regenerated the config option list (at the bottom of the file) from a new xml config doc dump, so all the snake case changes should be reflected there, as well as any other changes to those options.


Diffs (updated)
-----

  branches/12/configs/pjsip.conf.sample 404403 

Diff: https://reviewboard.asterisk.org/r/3086/diff/


Testing
-------

Only documentation outside of source code, doesn't appear to break anything.


Thanks,

rnewton

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131220/dd324449/attachment.html>


More information about the asterisk-dev mailing list