[asterisk-dev] [Code Review] Fax Gateway Implementation T30<->T38

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1116/#review3559
-----------------------------------------------------------


Ok i think we getting very close have got some good feedback on mantis #13405 have users using the 1.8 branch.

here a few minnor issues any feedback is welcome.

in the one release for 1.8 there was a mention this may be added in the cycle is this still a goal ?? do i work on a 
reasonable patch for 1.8 ?? the sip bits above have been committed to trunk this is IMHO a bug in 1.8 and a simple patch will solve it see below.

im hoping once the negotiation audit is done we will be good to go.

Greg



/team/irroot/t38gateway-trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1116/#comment7238>

    For asterisk 1.8 this could return _UNAVAILABLE if it is disabled to not break things and to be more correct ??
    
    this sip patch is in trunk now this is a "bug" in 1.8 maybe returning unavail on _DISABLED will be more correct and fix this ??
    
    is there still a plan to add T38-GW to 1.8 ??
    
    im maintaining a 1.8 branch now /team/irroot/t38gateway-1.8 that is getting more testing / feedback than trunk.
    
    



/team/irroot/t38gateway-trunk/res/res_fax_spandsp.c
<https://reviewboard.asterisk.org/r/1116/#comment7240>

    These need to be options passed to the system via FAXOPT esp transmit on idle.
    
    modems supported not really perhaps limit it on bitrate ??
    
    



/team/irroot/t38gateway-trunk/res/res_fax_spandsp.c
<https://reviewboard.asterisk.org/r/1116/#comment7239>

    With JB enabled f->data.ptr can be null this causes a segfault in spandsp.
    
    reported on matis by sles have commited fix in SVN.


- irroot


On 2011-05-16 04:45:08, irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1116/
> -----------------------------------------------------------
> 
> (Updated 2011-05-16 04:45:08)
> 
> 
> Review request for Asterisk Developers, Russell Bryant, Matthew Nicholson, dimas, may213, Leif Madsen, and dafe_von_cetin.
> 
> 
> Summary
> -------
> 
> Hi there the patch that was going around circa 2008 to implement this in 1.4/1.6 app_fax has been moved to trunk [1.10]
> ive made some cleanups and moved it into res_fax res_fax_spandsp this is the framework and not production code
> unfortunately i have no means of testing it at the moment and require help.
> 
> i have cleaned the code up substantially it is related to R459
> 
> hope this is found useful and aids in the goal to get it in 1.10.
> 
> Adds application FaxGateway / FaxDetect
> Adds alternate bridge to Dial with new option.
> 
> 
> This addresses bugs 13405, 19215 and 19251.
>     https://issues.asterisk.org/view.php?id=13405
>     https://issues.asterisk.org/view.php?id=19215
>     https://issues.asterisk.org/view.php?id=19251
> 
> 
> Diffs
> -----
> 
>   /team/irroot/t38gateway-trunk/CHANGES 318975 
>   /team/irroot/t38gateway-trunk/channels/chan_sip.c 318975 
>   /team/irroot/t38gateway-trunk/channels/sip/include/sip.h 318975 
>   /team/irroot/t38gateway-trunk/include/asterisk/res_fax.h 318975 
>   /team/irroot/t38gateway-trunk/res/res_fax.c 318975 
>   /team/irroot/t38gateway-trunk/res/res_fax_spandsp.c 318975 
> 
> Diff: https://reviewboard.asterisk.org/r/1116/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110517/6636fa22/attachment-0001.htm>