[asterisk-dev] [Code Review] Fax Gateway Implementation T30<->T38

[Matthew Nicholson]

> On 2011-05-17 08:35:47, irroot wrote:
> > /team/irroot/t38gateway-trunk/channels/chan_sip.c, lines 4304-4307
> > <https://reviewboard.asterisk.org/r/1116/diff/19/?file=16535#file16535line4304>
> >
> >     For asterisk 1.8 this could return _UNAVAILABLE if it is disabled to not break things and to be more correct ??
> >     
> >     this sip patch is in trunk now this is a "bug" in 1.8 maybe returning unavail on _DISABLED will be more correct and fix this ??
> >     
> >     is there still a plan to add T38-GW to 1.8 ??
> >     
> >     im maintaining a 1.8 branch now /team/irroot/t38gateway-1.8 that is getting more testing / feedback than trunk.
> >     
> >

Any change in behavior in what is returned in 1.8 may cause problems.  We will have to discuss this some more internally.  I agree that returning UNKNOWN is a bug.

I don't know if this will get added to 1.8 quite yet, but even if it is not added in the tree the 1.8 branch will support the required APIs for this functionality.  Users will be able to load it as a module.


> On 2011-05-17 08:35:47, irroot wrote:
> > /team/irroot/t38gateway-trunk/res/res_fax_spandsp.c, lines 689-692
> > <https://reviewboard.asterisk.org/r/1116/diff/19/?file=16539#file16539line689>
> >
> >     These need to be options passed to the system via FAXOPT esp transmit on idle.
> >     
> >     modems supported not really perhaps limit it on bitrate ??
> >     
> >

The fax details structure should support setting these options via the FAXOPT application. Although I don't believe there is a transmit on idle option in the details struct.  Special options for the gateway may need to be implemented in a second dialplan function.


> On 2011-05-17 08:35:47, irroot wrote:
> > /team/irroot/t38gateway-trunk/res/res_fax_spandsp.c, lines 720-728
> > <https://reviewboard.asterisk.org/r/1116/diff/19/?file=16539#file16539line720>
> >
> >     With JB enabled f->data.ptr can be null this causes a segfault in spandsp.
> >     
> >     reported on matis by sles have commited fix in SVN.

I saw that on mantis.  I wonder if f->samples should be 0 when f->data.ptr is null.  Could be a bug in asterisk, I'll check it out.


- Matthew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1116/#review3559
-----------------------------------------------------------


On 2011-05-16 04:45:08, irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1116/
> -----------------------------------------------------------
> 
> (Updated 2011-05-16 04:45:08)
> 
> 
> Review request for Asterisk Developers, Russell Bryant, Matthew Nicholson, dimas, may213, Leif Madsen, and dafe_von_cetin.
> 
> 
> Summary
> -------
> 
> Hi there the patch that was going around circa 2008 to implement this in 1.4/1.6 app_fax has been moved to trunk [1.10]
> ive made some cleanups and moved it into res_fax res_fax_spandsp this is the framework and not production code
> unfortunately i have no means of testing it at the moment and require help.
> 
> i have cleaned the code up substantially it is related to R459
> 
> hope this is found useful and aids in the goal to get it in 1.10.
> 
> Adds application FaxGateway / FaxDetect
> Adds alternate bridge to Dial with new option.
> 
> 
> This addresses bugs 13405, 19215 and 19251.
>     https://issues.asterisk.org/view.php?id=13405
>     https://issues.asterisk.org/view.php?id=19215
>     https://issues.asterisk.org/view.php?id=19251
> 
> 
> Diffs
> -----
> 
>   /team/irroot/t38gateway-trunk/CHANGES 318975 
>   /team/irroot/t38gateway-trunk/channels/chan_sip.c 318975 
>   /team/irroot/t38gateway-trunk/channels/sip/include/sip.h 318975 
>   /team/irroot/t38gateway-trunk/include/asterisk/res_fax.h 318975 
>   /team/irroot/t38gateway-trunk/res/res_fax.c 318975 
>   /team/irroot/t38gateway-trunk/res/res_fax_spandsp.c 318975 
> 
> Diff: https://reviewboard.asterisk.org/r/1116/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110517/db190903/attachment-0001.htm>