[asterisk-dev] [Code Review] Fax Gateway Implementation T30<->T38

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1116/
-----------------------------------------------------------

(Updated 2011-05-16 04:45:08.614920)


Review request for Asterisk Developers, Russell Bryant, Matthew Nicholson, dimas, may213, Leif Madsen, and dafe_von_cetin.


Changes
-------

This is in a dev branch.

http://svn.asterisk.org/svn/asterisk/team/irroot/t38gateway-trunk/
http://svn.asterisk.org/svn/asterisk/team/irroot/t38gateway-1.8/

* revert audio formats on detach of frame hook
* framehook cleans up properly
* update CHANGES
* prevent a negotiation storm
* we do not need to use a gen on T.38 (H/T may213 [added to reviewers])


Summary
-------

Hi there the patch that was going around circa 2008 to implement this in 1.4/1.6 app_fax has been moved to trunk [1.10]
ive made some cleanups and moved it into res_fax res_fax_spandsp this is the framework and not production code
unfortunately i have no means of testing it at the moment and require help.

i have cleaned the code up substantially it is related to R459

hope this is found useful and aids in the goal to get it in 1.10.

Adds application FaxGateway / FaxDetect
Adds alternate bridge to Dial with new option.


This addresses bugs 13405, 19215 and 19251.
    https://issues.asterisk.org/view.php?id=13405
    https://issues.asterisk.org/view.php?id=19215
    https://issues.asterisk.org/view.php?id=19251


Diffs (updated)
-----

  /team/irroot/t38gateway-trunk/CHANGES 318975 
  /team/irroot/t38gateway-trunk/channels/chan_sip.c 318975 
  /team/irroot/t38gateway-trunk/channels/sip/include/sip.h 318975 
  /team/irroot/t38gateway-trunk/include/asterisk/res_fax.h 318975 
  /team/irroot/t38gateway-trunk/res/res_fax.c 318975 
  /team/irroot/t38gateway-trunk/res/res_fax_spandsp.c 318975 

Diff: https://reviewboard.asterisk.org/r/1116/diff


Testing
-------


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110516/0a829cd3/attachment-0001.htm>