[Asterisk-code-review] channel_internal_api: Add LASTCONTEXT and LASTEXTEN (asterisk[master])

[N A]

Attention is currently required from: Sean Bright, Joshua Colp, Richard Mudgett.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17784 )

Change subject: channel_internal_api: Add LASTCONTEXT and LASTEXTEN
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2: 
> I agree with Sean.
My main concern here is the intuitiveness of the user experience. Wouldn't this be confusing to users? Since EXTEN is a channel variable, it seems reasonable that users would intuitively think to use LASTEXTEN instead (in fact, I looked for this variable on the wiki some time ago, because I could've sworn it existed, but didn't find it.)
My concern is this avoiding a problem which I don't really think exists may end up being more confusing in the process than otherwise... what if a user now expects that CHANNEL(EXTEN) will also work? LASTEXTEN doesn't really seem like a CHANNEL field type of thing...
Modules set status channel variables and such all the time, I guess I'm not sure what the concern is about a conflict now...
The other thing to consider is that if somebody was actually using LASTCONTEXT, it would probably be to manually be doing what this is already doing, so a user discovering such a conflict would be a good thing, if anything, because then they can use the built-in var and stop trying to set it themselves.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17784
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib455fe300cc8e9a127686896ee2d0bd11e900307
Gerrit-Change-Number: 17784
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 07 Jan 2022 02:30:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220106/bdec667e/attachment.html>