[Asterisk-code-review] channel_internal_api: Add LASTCONTEXT and LASTEXTEN (asterisk[master])

[Joshua Colp]

Attention is currently required from: Sean Bright, N A, Richard Mudgett.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17784 )

Change subject: channel_internal_api: Add LASTCONTEXT and LASTEXTEN
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2: 
> My main concern here is the intuitiveness of the user experience. […]
EXTEN and other internal variables predate dialplan functions, it's why they are done the way they are. Just because of that it doesn't mean we should continue to do things that way. As for LASTEXTEN/LASTCONTEXT we don't know if or if not a problem exists here, we can only try to prevent it. Other modules have no mechanism to easily not use dialplan variables for state information except for exposing their own dialplan function with datastores (which some newer stuff actually does). Channels do already, via the func_channel mechanism. It's also better because it is automatically documented as part of func_channel. Special internal variables ARE NOT easily documented. You have to manually add them to the wiki, or other places, and in fact there's likely ones that people have no idea exist because there's no good way to document them and people forgot.

I continue to support making this part of func_channel.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17784
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib455fe300cc8e9a127686896ee2d0bd11e900307
Gerrit-Change-Number: 17784
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 07 Jan 2022 10:10:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220107/881e4d2c/attachment.html>