<p> Attention is currently required from: Sean Bright, Joshua Colp, Richard Mudgett. </p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/17784">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="null">Patchset:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/17784?tab=comments">Patch Set #2:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I agree with Sean.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">My main concern here is the intuitiveness of the user experience. Wouldn't this be confusing to users? Since EXTEN is a channel variable, it seems reasonable that users would intuitively think to use LASTEXTEN instead (in fact, I looked for this variable on the wiki some time ago, because I could've sworn it existed, but didn't find it.)<br>My concern is this avoiding a problem which I don't really think exists may end up being more confusing in the process than otherwise... what if a user now expects that CHANNEL(EXTEN) will also work? LASTEXTEN doesn't really seem like a CHANNEL field type of thing...<br>Modules set status channel variables and such all the time, I guess I'm not sure what the concern is about a conflict now...<br>The other thing to consider is that if somebody was actually using LASTCONTEXT, it would probably be to manually be doing what this is already doing, so a user discovering such a conflict would be a good thing, if anything, because then they can use the built-in var and stop trying to set it themselves.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/17784">change 17784</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/17784"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib455fe300cc8e9a127686896ee2d0bd11e900307 </div>
<div style="display:none"> Gerrit-Change-Number: 17784 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-CC: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-CC: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Attention: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Gerrit-Attention: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Gerrit-Attention: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 07 Jan 2022 02:30:38 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Sean Bright <sean@seanbright.com> </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@sangoma.com> </div>
<div style="display:none"> Comment-In-Reply-To: N A <mail@interlinked.x10host.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>