[Asterisk-code-review] app_queue: Fix hint updates, allow dup. hints (asterisk[16])

[N A]

Attention is currently required from: Steve Davies.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17658 )

Change subject: app_queue: Fix hint updates, allow dup. hints
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/17658/comment/f43c120c_137003f5 
PS2, Line 2713: 				found = 1;
If you're not going to break out of the loop here, then I think the if (found) code below should be moved into this true branch. Otherwise, I believe if there is a match and we continue executing in the loop, there will only be a debug message logged for the last match, but there should be one for every match.

If you do this, the found variable itself could also be done away with.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17658
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: If2c1d1cc2a752afd9286d79710fc818596e7a7ad
Gerrit-Change-Number: 17658
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Davies <steve at one47.co.uk>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Steve Davies <steve at one47.co.uk>
Gerrit-Comment-Date: Wed, 15 Dec 2021 13:41:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211215/4378db04/attachment.html>