[Asterisk-code-review] app_queue: Fix hint updates, allow dup. hints (asterisk[16])

[Steve Davies]

Attention is currently required from: Joshua Colp, N A.
Steve Davies has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17658 )

Change subject: app_queue: Fix hint updates, allow dup. hints
......................................................................


Patch Set 2:

(3 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/17658/comment/2603512b_e3efdc03 
PS1, Line 7:     app_queue: Fix hint updates, allow dup. hints
> Indented
Done


https://gerrit.asterisk.org/c/asterisk/+/17658/comment/f2bd2bb7_ef5082aa 
PS1, Line 20:     ASTERISK-29578 #close
> Please create a separate issue for this, it makes the release notes more specific about what was fix […]
Done


File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/17658/comment/755d1b43_387c5b5c 
PS2, Line 2713: 				found = 1;
> If you're not going to break out of the loop here, then I think the if (found) code below should be  […]
I considered this, but the log contains only information from the device state that is being received, and nothing specific to the queue or member being updated, so doing this would result in duplicate messages.

Perhaps `found++` and indicate number of matches in the log message instead?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17658
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: If2c1d1cc2a752afd9286d79710fc818596e7a7ad
Gerrit-Change-Number: 17658
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Davies <steve at one47.co.uk>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Wed, 15 Dec 2021 13:55:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211215/b61a601c/attachment.html>