[Asterisk-code-review] app_queue: Fix hint updates, allow dup. hints (asterisk[16])

[Richard Mudgett]

Attention is currently required from: Steve Davies.
Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17658 )

Change subject: app_queue: Fix hint updates, allow dup. hints
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/17658/comment/9a30edfb_f2644021 
PS2, Line 9: A previous patch for ASTERISK-29578 caused a 'leak' of
References to other issues should have the '-' in the issue ID changed to either '~" or '_'.  This is so the gerrit plugin does not mess with the other issues when the patch is merged.


File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/17658/comment/e276fc12_6f56a052 
PS2, Line 2711: 			if (!strcmp(m->state_exten, exten) && (!strcmp(m->state_context, context) || context_included(m->state_context, context))) {
This line is too long.  Put a line break at the && to preserve expression grouping when wrapping the long line.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17658
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: If2c1d1cc2a752afd9286d79710fc818596e7a7ad
Gerrit-Change-Number: 17658
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Davies <steve at one47.co.uk>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Steve Davies <steve at one47.co.uk>
Gerrit-Comment-Date: Wed, 15 Dec 2021 13:28:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20211215/93d30b78/attachment.html>