[Asterisk-code-review] app_chanisavail/cdr: ChanIsAvail sometimes fails to deactivate CDR. (asterisk[16])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13310 )

Change subject: app_chanisavail/cdr: ChanIsAvail sometimes fails to deactivate CDR.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/13310/1/apps/app_chanisavail.c 
File apps/app_chanisavail.c:

https://gerrit.asterisk.org/c/asterisk/+/13310/1/apps/app_chanisavail.c@182 
PS1, Line 182: 					/* XXX Should this be conditioned to an option, due to performance cost? */
> Thank you for the review, and for your suggestion about cdr_sync_message_type(): used with stasis_me […]
I think adding it to the ast_cdr_* functions is reasonable. I don't think it needs to go into cli_show_channel. I'd hesitate on adding it to cdr_object_get_by_name, as I think it's a detail of the API between the rest of Asterisk and CDRs.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13310
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I1cbe09e8d2169c0962c1195133ff260d291f2074
Gerrit-Change-Number: 13310
Gerrit-PatchSet: 1
Gerrit-Owner: Frederic LE FOLL <frederic.lefoll at c-s.fr>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 03 Dec 2019 11:12:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at digium.com>
Comment-In-Reply-To: Frederic LE FOLL <frederic.lefoll at c-s.fr>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191203/1836fecd/attachment.html>