[Asterisk-code-review] app_chanisavail/cdr: ChanIsAvail sometimes fails to deactivate CDR. (asterisk[16])

[Frederic LE FOLL]

Frederic LE FOLL has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13310 )

Change subject: app_chanisavail/cdr: ChanIsAvail sometimes fails to deactivate CDR.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/13310/1/apps/app_chanisavail.c 
File apps/app_chanisavail.c:

https://gerrit.asterisk.org/c/asterisk/+/13310/1/apps/app_chanisavail.c@182 
PS1, Line 182: 					/* XXX Should this be conditioned to an option, due to performance cost? */
> I don't think this is the correct solution. […]
Thank you for the review, and for your suggestion about cdr_sync_message_type(): used with stasis_message_router_publish_sync() as in ast_cdr_engine_term(), I understand that it will enable indeed to wait for previous messages to be processed (not only, but including, the ast_channel_snapshot_type() that should make CDR available in active_cdrs_master container).

But - maybe I am extrapolating too fast -, should it also apply to other functions looking for CDR in active_cdrs_master, and giving up if not found - with or without a log -, such as:
- ast_cdr_getvar(),
- ast_cdr_serialize_variables(),
- ast_cdr_setuserfield(),
- ast_cdr_clear_property(),
- ast_cdr_reset(),
- ast_cdr_fork(),
- cli_show_channel() (more uncertain about this one) ?
Or should this use of cdr_sync_message_type() even integrate directly cdr_object_get_by_name() ?

I hope I can run new tests and submit a new Patch Set before the end of the week.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13310
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I1cbe09e8d2169c0962c1195133ff260d291f2074
Gerrit-Change-Number: 13310
Gerrit-PatchSet: 1
Gerrit-Owner: Frederic LE FOLL <frederic.lefoll at c-s.fr>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 02 Dec 2019 18:16:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191202/ba9a4f8c/attachment.html>