[Asterisk-code-review] app_chanisavail/cdr: ChanIsAvail sometimes fails to deactivate CDR. (asterisk[16])

[Frederic LE FOLL]

Frederic LE FOLL has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13310 )

Change subject: app_chanisavail/cdr: ChanIsAvail sometimes fails to deactivate CDR.
......................................................................


Patch Set 1:

Adding a cdr_sync() call in ast_cdr_set_property() [with the same code as in ast_cdr_engine_term()], in order to sync and retry if first cdr_object_get_by_name() fails, works fine, although it sometimes implies longer delays [compared to "just wait and retry loop" approach].

But if I simulate a first cdr_object_get_by_name() failure [just ... not calling the function and initializing cdr to NULL], NoCDR application locks and 'core show locks' shows two threads locked: an inspection with gdb shows that first one is running nocdr_exec() and second one is running appcdr_callback().
I am not sure that this simulation is relevant but I think I need to investigate before submitting the new Patch Set.

Next update coming soon.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13310
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I1cbe09e8d2169c0962c1195133ff260d291f2074
Gerrit-Change-Number: 13310
Gerrit-PatchSet: 1
Gerrit-Owner: Frederic LE FOLL <frederic.lefoll at c-s.fr>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Fri, 06 Dec 2019 18:04:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191206/1956eafa/attachment.html>