[Asterisk-doc] docs appendix03.xml,1.20,1.21 chapter01.xml,1.4,1.5 chapter02.xml,1.6,1.7 chapter03.xml,1.4,1.5 chapter04.xml,1.2,1.3 chapter06.xml,1.6,1.7 chapter07.xml,1.9,1.10 words.list,1.2,1.3

[Steven Critchfield]

On Fri, 2004-01-02 at 17:01, websmith wrote:

> ***************
> *** 1393,1397 ****
>   </para>
>   
> ! <formalpara><title>SIPDtmfMode: Change the dtmfmode for a SIP call</title>
>   <para>
>   	<function>SIPDtmfMode(<replaceable>option</replaceable>)</function>
> --- 1393,1397 ----
>   </para>
>   
> ! <formalpara><title>SIPDtmfMode: Change the DTMF mode for a SIP call</title>
>   <para>
>   	<function>SIPDtmfMode(<replaceable>option</replaceable>)</function>
> ***************
> *** 1399,1403 ****
>   </formalpara>
>   <para>
> ! 	Changes the dtmfmode for a SIP call
>   </para>
>   <para>
> --- 1399,1403 ----
>   </formalpara>
>   <para>
> ! 	Changes the DTMF mode for a SIP call
>   </para>
>   <para>


I'm a bit concerned about thee changes. I skipped them before due to the
fact that the keyword in the config file as dtmfmode. Some times I think
that a not properly split or capitalized term is acceptable since it
directly references a keyword from a config file. 


> Index: chapter06.xml
> ===================================================================
> RCS file: /cvsroot/asterisk/docs/chapter06.xml,v
> retrieving revision 1.6
> retrieving revision 1.7
> diff -C2 -d -r1.6 -r1.7
> *** chapter06.xml	2 Jan 2004 01:40:57 -0000	1.6
> --- chapter06.xml	2 Jan 2004 23:01:52 -0000	1.7
> ***************
> *** 106,110 ****
>   
>   				[agents]
> ! 				; Automatic logoff if an agent rings for too long, in seconds. 
>   				; This is not useful for AgentLogin, because calls are automatically
>   				; answered.
> --- 106,110 ----
>   
>   				[agents]
> ! 				; Automatic log-off if an agent rings for too long, in seconds. 
>   				; This is not useful for AgentLogin, because calls are automatically
>   				; answered.

While log-off is probably more correct, I think logoff is an accepted
form. 

> ***************
> *** 251,258 ****
>   
>   			<para>
> ! 				You can configure signalling and all just as though they were T1's or
>   				E1's, so you can run RBS or you can run PRI or whatever, they even
>   				generate RED and YELLOW alarm just like real T1's and E1's. We're still
> ! 				debating whether you can run ccs on it.
>   			</para>
>   
> --- 251,258 ----
>   
>   			<para>
> ! 				You can configure signaling and all just as though they were T1's or
>   				E1's, so you can run RBS or you can run PRI or whatever, they even
>   				generate RED and YELLOW alarm just like real T1's and E1's. We're still
> ! 				debating whether you can run CCS on it.
>   			</para>

This one also is on of my annoyances. I understand that the single L
version of signaling is supposedly correct according to my spell
checker, but I keep wanting to put 2 Ls and the keyword in the configs
has 2 Ls. Maybe someone should write a patch to asterisk to fix it, and
allow for backward compatible misspellings too.

  
> ***************
> *** 308,312 ****
>   			<para>
>   				<programlisting>
> ! 				signalling=em
>   				channel=>2-31
>   				</programlisting>
> --- 308,312 ----
>   			<para>
>   				<programlisting>
> ! 				signaling=em
>   				channel=>2-31
>   				</programlisting>
> ***************
> *** 317,321 ****
>   			<para>
>   				<programlisting>
> ! 				signalling=em
>   				channel=>1-30
>   				</programlisting>
> --- 317,321 ----
>   			<para>
>   				<programlisting>
> ! 				signaling=em
>   				channel=>1-30
>   				</programlisting>

See this is where the spelling change would become a problem as the code
is looking for the double L spelling of the word.  

-- 
Steven Critchfield <critch@basesys.com>