[asterisk-dev] Questions on feature/patch process

[Dan Cropp]

Thank you Florian


From: asterisk-dev <asterisk-dev-bounces at lists.digium.com> On Behalf Of Floimair Florian
Sent: Monday, April 8, 2019 2:46 AM
To: Asterisk Developers Mailing List <asterisk-dev at lists.digium.com>
Subject: Re: [asterisk-dev] Questions on feature/patch process

Yes, you need to cherry-pick your patch to branch 16.
You can do this directly in gerrit though.
Be prepared however, that there might be modifications necessary.
I therefore personally prefer to do such things locally first in separate branches and then submit the changes on each branch individually for review.



With best regards

Florian Floimair
Innovation - Software-Development

COMMEND INTERNATIONAL GMBH
A-5020 Salzburg, Saalachstraße 51
http://www.commend.com<http://www.commend.com/>

Security and Communication by Commend

FN 178618z | LG Salzburg

Von: asterisk-dev <asterisk-dev-bounces at lists.digium.com<mailto:asterisk-dev-bounces at lists.digium.com>> im Auftrag von Dan Cropp <dan at amtelco.com<mailto:dan at amtelco.com>>
Antworten an: Asterisk Developers Mailing List <asterisk-dev at lists.digium.com<mailto:asterisk-dev at lists.digium.com>>
Datum: Samstag, 6. April 2019 um 00:05
An: Asterisk Developers Mailing List <asterisk-dev at lists.digium.com<mailto:asterisk-dev at lists.digium.com>>
Betreff: [asterisk-dev] Questions on feature/patch process

I submitted a patch to git review earlier this week.  I submitted it based on master branch for the issue I worked on.
If we would like this to be part of a future asterisk 16 version, do I need to do any additional work for this using asterisk 16 as the source branch?

Also, I have code to allow enabling/disabling the norefersub on PJSIP.  This is due to issues with Cisco not adhering to the standard.
From what we’ve been able to tell, PJPROJECT has a way to add the capability, but no way to remove it.  Based on this, we believe the setting would be a global PJSIP setting to enable the norefersub by default, but allow it not to be added as a capability for PJPROJECT if the setting is no (pjsip_refer load module).
Does this sound like the reasonable approach?  Ideally, the setting would be per endpoint, but that doesn’t seem possible with PJPROJECT.

Have a great day!

Dan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20190408/8187de6e/attachment-0001.html>