[asterisk-dev] [Code Review] 4327: Various fixes for OS X

[David Lee]

> On Jan. 23, 2015, 9:54 a.m., Matt Jordan wrote:
> > /branches/13/main/rtp_engine.c, lines 1949-1952
> > <https://reviewboard.asterisk.org/r/4327/diff/3/?file=70526#file70526line1949>
> >
> >     You got overcome by events here: these should be cast to unsigned long.
> >     
> >     It may no longer trip a compiler warning, however.

It's a weird __darwin_suseconds_t on OS X, which is why the cast is needed.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4327/#review14270
-----------------------------------------------------------


On Jan. 23, 2015, 12:02 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4327/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2015, 12:02 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch addresses compilation errors on OS X. It's been a while, so
> there's quite a few things.
> 
>  * Fixed __attribute__ decls in route.h to be portable.
>  * Fixed htonll and ntohll to work when they are defined as macros.
>  * Replaced sem_t usage with our ast_sem wrapper.
>  * Added ast_sem_timedwait to our ast_sem wrapper.
>  * Fixed some GCC 4.9 warnings using sig*set() functions.
>  * Fixed some format strings for portability.
> 
> 
> Diffs
> -----
> 
>   /branches/13/res/res_timing_kqueue.c 431029 
>   /branches/13/main/sem.c 431029 
>   /branches/13/main/rtp_engine.c 431029 
>   /branches/13/main/bridge_channel.c 431029 
>   /branches/13/main/asterisk.c 431029 
>   /branches/13/main/app.c 431029 
>   /branches/13/include/asterisk/sem.h 431029 
>   /branches/13/include/asterisk/autoconfig.h.in 431029 
>   /branches/13/funcs/func_presencestate.c 431029 
>   /branches/13/configure.ac 431029 
>   /branches/13/configure UNKNOWN 
>   /branches/13/channels/sip/include/route.h 431029 
> 
> Diff: https://reviewboard.asterisk.org/r/4327/diff/
> 
> 
> Testing
> -------
> 
> Compiled on both OS X and Linux.
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150123/ce3fb089/attachment.html>