[asterisk-dev] [Code Review] 4327: Various fixes for OS X

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4327/#review14270
-----------------------------------------------------------

Ship it!


Since I don't use OS X, I don't have 'skin in the game', so to speak, on whether or not this patch makes Asterisk compile better on OS X.

On the other hand, I do want to make sure things still compile just fine on Linux, and using gcc 4.8.2, things look good. If there are additional issues with this patch with respect to OS X, then I'll trust that those who do use Asterisk with OS X will sort them out.

A few small comments here and there, but nothing that should hold up this patch.


/branches/13/main/rtp_engine.c
<https://reviewboard.asterisk.org/r/4327/#comment24755>

    You got overcome by events here: these should be cast to unsigned long.
    
    It may no longer trip a compiler warning, however.



/branches/13/res/res_pjsip_config_wizard.c
<https://reviewboard.asterisk.org/r/4327/#comment24756>

    If you don't mind, this should probably be a separate commit.



/branches/13/res/res_timing_kqueue.c
<https://reviewboard.asterisk.org/r/4327/#comment24757>

    And I would guess that the fixes to res_timing_kqueue should be in a separate commit as well.


- Matt Jordan


On Jan. 13, 2015, 8:14 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4327/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2015, 8:14 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch addresses compilation errors on OS X. It's been a while, so
> there's quite a few things.
> 
>  * Fixed __attribute__ decls in route.h to be portable.
>  * Fixed htonll and ntohll to work when they are defined as macros.
>  * Replaced sem_t usage with our ast_sem wrapper.
>  * Added ast_sem_timedwait to our ast_sem wrapper.
>  * Fixed some GCC 4.9 warnings using sig*set() functions.
>  * Fixed some format strings for portability.
>  * Added pjproject dependency to res_pjsip_config_wizard.c.
> 
> 
> Diffs
> -----
> 
>   /branches/13/res/res_timing_kqueue.c 430428 
>   /branches/13/res/res_pjsip_config_wizard.c 430428 
>   /branches/13/main/sem.c 430428 
>   /branches/13/main/rtp_engine.c 430428 
>   /branches/13/main/bridge_channel.c 430428 
>   /branches/13/main/asterisk.c 430428 
>   /branches/13/main/app.c 430428 
>   /branches/13/include/asterisk/sem.h 430428 
>   /branches/13/include/asterisk/autoconfig.h.in 430428 
>   /branches/13/funcs/func_presencestate.c 430428 
>   /branches/13/configure.ac 430428 
>   /branches/13/configure UNKNOWN 
>   /branches/13/channels/sip/include/route.h 430428 
> 
> Diff: https://reviewboard.asterisk.org/r/4327/diff/
> 
> 
> Testing
> -------
> 
> Compiled on both OS X and Linux.
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150123/17edb468/attachment-0001.html>