<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4327/">https://reviewboard.asterisk.org/r/4327/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 23rd, 2015, 9:54 a.m. CST, <b>Matt Jordan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/4327/diff/3/?file=70526#file70526line1949" style="color: black; font-weight: bold; text-decoration: underline;">/branches/13/main/rtp_engine.c</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static struct ast_json *rtcp_report_to_json(struct stasis_message *msg,</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1949</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="kt">char</span> <span class="n">usec</span><span class="p">[</span><span class="mi">32</span><span class="p">];</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1949</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="kt">char</span> <span class="n">usec</span><span class="p">[</span><span class="mi">32</span><span class="p">];</span></pre></td>
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1950</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="n">snprintf</span><span class="p">(</span><span class="n">sec</span><span class="p">,</span> <span class="k">sizeof</span><span class="p">(</span><span class="n">sec</span><span class="p">),</span> <span class="s">"%ld"</span><span class="p">,</span> <span class="n">payload</span><span class="o">-></span><span class="n">report</span><span class="o">-></span><span class="n">sender_information</span><span class="p">.</span><span class="n">ntp_timestamp</span><span class="p">.</span><span class="n">tv_sec</span><span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1950</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="n">snprintf</span><span class="p">(</span><span class="n">sec</span><span class="p">,</span> <span class="k">sizeof</span><span class="p">(</span><span class="n">sec</span><span class="p">),</span> <span class="s">"%ld"</span><span class="p">,</span> <span class="n">payload</span><span class="o">-></span><span class="n">report</span><span class="o">-></span><span class="n">sender_information</span><span class="p">.</span><span class="n">ntp_timestamp</span><span class="p">.</span><span class="n">tv_sec</span><span class="p">);</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1951</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="n">snprintf</span><span class="p">(</span><span class="n">usec</span><span class="p">,</span> <span class="k">sizeof</span><span class="p">(</span><span class="n">usec</span><span class="p">),</span> <span class="s">"%ld"</span><span class="p">,</span> <span class="n">payload</span><span class="o">-></span><span class="n">report</span><span class="o">-></span><span class="n">sender_information</span><span class="p">.</span><span class="n">ntp_timestamp</span><span class="p">.</span><span class="n">tv_usec</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1951</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="n">snprintf</span><span class="p">(</span><span class="n">usec</span><span class="p">,</span> <span class="k">sizeof</span><span class="p">(</span><span class="n">usec</span><span class="p">),</span> <span class="s">"%ld"</span><span class="p">,</span> <span class="p"><span class="hl">(</span></span><span class="kt"><span class="hl">long</span></span><span class="p"><span class="hl">)</span></span><span class="n">payload</span><span class="o">-></span><span class="n">report</span><span class="o">-></span><span class="n">sender_information</span><span class="p">.</span><span class="n">ntp_timestamp</span><span class="p">.</span><span class="n">tv_usec</span><span class="p">);</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1952</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="n">json_rtcp_sender_info</span> <span class="o">=</span> <span class="n">ast_json_pack</span><span class="p">(</span><span class="s">"{s: s, s: s, s: i, s: i, s: i}"</span><span class="p">,</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1952</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="tb"> </span><span class="n">json_rtcp_sender_info</span> <span class="o">=</span> <span class="n">ast_json_pack</span><span class="p">(</span><span class="s">"{s: s, s: s, s: i, s: i, s: i}"</span><span class="p">,</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You got overcome by events here: these should be cast to unsigned long.
It may no longer trip a compiler warning, however.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's a weird __darwin_suseconds_t on OS X, which is why the cast is needed.</pre>
<br />
<p>- David</p>
<br />
<p>On January 23rd, 2015, 12:02 p.m. CST, David Lee wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By David Lee.</div>
<p style="color: grey;"><i>Updated Jan. 23, 2015, 12:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch addresses compilation errors on OS X. It's been a while, so
there's quite a few things.
* Fixed __attribute__ decls in route.h to be portable.
* Fixed htonll and ntohll to work when they are defined as macros.
* Replaced sem_t usage with our ast_sem wrapper.
* Added ast_sem_timedwait to our ast_sem wrapper.
* Fixed some GCC 4.9 warnings using sig*set() functions.
* Fixed some format strings for portability.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled on both OS X and Linux.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/13/res/res_timing_kqueue.c <span style="color: grey">(431029)</span></li>
<li>/branches/13/main/sem.c <span style="color: grey">(431029)</span></li>
<li>/branches/13/main/rtp_engine.c <span style="color: grey">(431029)</span></li>
<li>/branches/13/main/bridge_channel.c <span style="color: grey">(431029)</span></li>
<li>/branches/13/main/asterisk.c <span style="color: grey">(431029)</span></li>
<li>/branches/13/main/app.c <span style="color: grey">(431029)</span></li>
<li>/branches/13/include/asterisk/sem.h <span style="color: grey">(431029)</span></li>
<li>/branches/13/include/asterisk/autoconfig.h.in <span style="color: grey">(431029)</span></li>
<li>/branches/13/funcs/func_presencestate.c <span style="color: grey">(431029)</span></li>
<li>/branches/13/configure.ac <span style="color: grey">(431029)</span></li>
<li>/branches/13/configure <span style="color: grey">(UNKNOWN)</span></li>
<li>/branches/13/channels/sip/include/route.h <span style="color: grey">(431029)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4327/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>