[asterisk-dev] [Code Review] 4327: Various fixes for OS X

[David Lee]

> On Jan. 9, 2015, 11:16 a.m., George Joseph wrote:
> > There are a few recent issues that I think this addresses...
> > ASTERISK-24539
> > ASTERISK-24544
> > 
> > Does this patch also address
> > ASTERISK-24559
> > ASTERISK-24565
> > ?
> > 
> >
> 
> David Lee wrote:
>     > ASTERISK-24539
>     > ASTERISK-24544
>     
>     Yes.
>     
>     > ASTERISK-24559
>     
>     Probably not.
>     
>     > ASTERISK-24565
>     
>     No.
> 
> George Joseph wrote:
>     Ok, can you add the 2 yeses to the review?

For ASTERISK-24559 (app_voicemail notify_new_message() forked process crashes on OS X), that beyond my current scope.

For ASTERISK-24565 (kqueue not working correctly on OSX), I did fix the compile errors, but it still doesn't function properly. I spent a few minutes looking at it, but it looks pretty fundamentally broken to me. (As in the kqueue code there doesn't line up with kqueue timer examples that I see.) I wouldn't know how to get it to work without learning a lot more about kqueue than I care to learn.

FWIW, it appears in r271657, there was an attempt to disable kqueue on OS X anyways, but the <conflict> statement that was introduced doesn't seem to be doing that anyways. I may try to fix that, so in the very least no one tries to use it on OS X.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4327/#review14151
-----------------------------------------------------------


On Jan. 9, 2015, 5:31 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4327/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2015, 5:31 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch addresses compilation errors on OS X. It's been a while, so
> there's quite a few things.
> 
>  * Fixed __attribute__ decls in route.h to be portable.
>  * Fixed htonll and ntohll to work when they are defined as macros.
>  * Replaced sem_t usage with our ast_sem wrapper.
>  * Added ast_sem_timedwait to our ast_sem wrapper.
>  * Fixed some GCC 4.9 warnings using sig*set() functions.
>  * Fixed some format strings for portability.
>  * Added pjproject dependency to res_pjsip_config_wizard.c.
> 
> 
> Diffs
> -----
> 
>   /branches/13/res/res_timing_kqueue.c 430428 
>   /branches/13/res/res_pjsip_config_wizard.c 430428 
>   /branches/13/main/sem.c 430428 
>   /branches/13/main/rtp_engine.c 430428 
>   /branches/13/main/bridge_channel.c 430428 
>   /branches/13/main/asterisk.c 430428 
>   /branches/13/main/app.c 430428 
>   /branches/13/include/asterisk/sem.h 430428 
>   /branches/13/include/asterisk/autoconfig.h.in 430428 
>   /branches/13/funcs/func_presencestate.c 430428 
>   /branches/13/configure.ac 430428 
>   /branches/13/configure UNKNOWN 
>   /branches/13/channels/sip/include/route.h 430428 
> 
> Diff: https://reviewboard.asterisk.org/r/4327/diff/
> 
> 
> Testing
> -------
> 
> Compiled on both OS X and Linux.
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150109/b851761e/attachment.html>