<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4327/">https://reviewboard.asterisk.org/r/4327/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 9th, 2015, 11:16 a.m. CST, <b>George Joseph</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There are a few recent issues that I think this addresses...
ASTERISK-24539
ASTERISK-24544
Does this patch also address
ASTERISK-24559
ASTERISK-24565
?
</pre>
</blockquote>
<p>On January 9th, 2015, 11:52 a.m. CST, <b>David Lee</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> ASTERISK-24539
> ASTERISK-24544
Yes.
> ASTERISK-24559
Probably not.
> ASTERISK-24565
No.</pre>
</blockquote>
<p>On January 9th, 2015, 12:10 p.m. CST, <b>George Joseph</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, can you add the 2 yeses to the review?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For ASTERISK-24559 (app_voicemail notify_new_message() forked process crashes on OS X), that beyond my current scope.
For ASTERISK-24565 (kqueue not working correctly on OSX), I did fix the compile errors, but it still doesn't function properly. I spent a few minutes looking at it, but it looks pretty fundamentally broken to me. (As in the kqueue code there doesn't line up with kqueue timer examples that I see.) I wouldn't know how to get it to work without learning a lot more about kqueue than I care to learn.
FWIW, it appears in r271657, there was an attempt to disable kqueue on OS X anyways, but the <conflict> statement that was introduced doesn't seem to be doing that anyways. I may try to fix that, so in the very least no one tries to use it on OS X.</pre>
<br />
<p>- David</p>
<br />
<p>On January 9th, 2015, 5:31 p.m. CST, David Lee wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By David Lee.</div>
<p style="color: grey;"><i>Updated Jan. 9, 2015, 5:31 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch addresses compilation errors on OS X. It's been a while, so
there's quite a few things.
* Fixed __attribute__ decls in route.h to be portable.
* Fixed htonll and ntohll to work when they are defined as macros.
* Replaced sem_t usage with our ast_sem wrapper.
* Added ast_sem_timedwait to our ast_sem wrapper.
* Fixed some GCC 4.9 warnings using sig*set() functions.
* Fixed some format strings for portability.
* Added pjproject dependency to res_pjsip_config_wizard.c.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled on both OS X and Linux.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/13/res/res_timing_kqueue.c <span style="color: grey">(430428)</span></li>
<li>/branches/13/res/res_pjsip_config_wizard.c <span style="color: grey">(430428)</span></li>
<li>/branches/13/main/sem.c <span style="color: grey">(430428)</span></li>
<li>/branches/13/main/rtp_engine.c <span style="color: grey">(430428)</span></li>
<li>/branches/13/main/bridge_channel.c <span style="color: grey">(430428)</span></li>
<li>/branches/13/main/asterisk.c <span style="color: grey">(430428)</span></li>
<li>/branches/13/main/app.c <span style="color: grey">(430428)</span></li>
<li>/branches/13/include/asterisk/sem.h <span style="color: grey">(430428)</span></li>
<li>/branches/13/include/asterisk/autoconfig.h.in <span style="color: grey">(430428)</span></li>
<li>/branches/13/funcs/func_presencestate.c <span style="color: grey">(430428)</span></li>
<li>/branches/13/configure.ac <span style="color: grey">(430428)</span></li>
<li>/branches/13/configure <span style="color: grey">(UNKNOWN)</span></li>
<li>/branches/13/channels/sip/include/route.h <span style="color: grey">(430428)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4327/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>