[asterisk-dev] [Code Review] 4327: Various fixes for OS X

David Lee reviewboard at asterisk.org
Fri Jan 9 17:31:28 CST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4327/
-----------------------------------------------------------

(Updated Jan. 9, 2015, 5:31 p.m.)


Review request for Asterisk Developers.


Changes
-------

Fixed compile errors for res_timing_kqueue.c


Repository: Asterisk


Description
-------

This patch addresses compilation errors on OS X. It's been a while, so
there's quite a few things.

 * Fixed __attribute__ decls in route.h to be portable.
 * Fixed htonll and ntohll to work when they are defined as macros.
 * Replaced sem_t usage with our ast_sem wrapper.
 * Added ast_sem_timedwait to our ast_sem wrapper.
 * Fixed some GCC 4.9 warnings using sig*set() functions.
 * Fixed some format strings for portability.
 * Added pjproject dependency to res_pjsip_config_wizard.c.


Diffs (updated)
-----

  /branches/13/res/res_timing_kqueue.c 430428 
  /branches/13/res/res_pjsip_config_wizard.c 430428 
  /branches/13/main/sem.c 430428 
  /branches/13/main/rtp_engine.c 430428 
  /branches/13/main/bridge_channel.c 430428 
  /branches/13/main/asterisk.c 430428 
  /branches/13/main/app.c 430428 
  /branches/13/include/asterisk/sem.h 430428 
  /branches/13/include/asterisk/autoconfig.h.in 430428 
  /branches/13/funcs/func_presencestate.c 430428 
  /branches/13/configure.ac 430428 
  /branches/13/configure UNKNOWN 
  /branches/13/channels/sip/include/route.h 430428 

Diff: https://reviewboard.asterisk.org/r/4327/diff/


Testing
-------

Compiled on both OS X and Linux.


Thanks,

David Lee

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150109/4966415b/attachment.html>


More information about the asterisk-dev mailing list