[asterisk-dev] [Code Review] 3541: res_http_websocket: Create a websocket client

[Kevin Harwell]

> On May 20, 2014, 5:55 a.m., Joshua Colp wrote:
> > trunk/include/asterisk/http_websocket.h, line 259
> > <https://reviewboard.asterisk.org/r/3541/diff/1/?file=58458#file58458line259>
> >
> >     It would be useful to return why it failed and not just that it did.

I don't quite understand.  Are you thinking an error string should be passed in and "filled" on failure?  There are errors currently logged on error conditions


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3541/#review11903
-----------------------------------------------------------


On May 15, 2014, 1:10 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3541/
> -----------------------------------------------------------
> 
> (Updated May 15, 2014, 1:10 p.m.)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Bugs: ASTERISK-23742
>     https://issues.asterisk.org/jira/browse/ASTERISK-23742
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Add client websocket capabilities to Asterisk.
> 
> 
> Diffs
> -----
> 
>   trunk/tests/test_websocket_client.c PRE-CREATION 
>   trunk/res/res_http_websocket.exports.in 413541 
>   trunk/res/res_http_websocket.c 413541 
>   trunk/main/http.c 413541 
>   trunk/include/asterisk/http_websocket.h 413541 
>   trunk/include/asterisk/http.h 413541 
> 
> Diff: https://reviewboard.asterisk.org/r/3541/diff/
> 
> 
> Testing
> -------
> 
> Created some unit tests.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140520/7aade00b/attachment.html>