[asterisk-dev] [Code Review] 3541: res_http_websocket: Create a websocket client

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3541/#review11903
-----------------------------------------------------------



trunk/include/asterisk/http_websocket.h
<https://reviewboard.asterisk.org/r/3541/#comment21788>

    This is a bit ambiguous. Do...
    
    Supported WebSocket versions in server implementation:
    
    Supported WebSocket versions in client implementation:



trunk/include/asterisk/http_websocket.h
<https://reviewboard.asterisk.org/r/3541/#comment21799>

    checked



trunk/include/asterisk/http_websocket.h
<https://reviewboard.asterisk.org/r/3541/#comment21803>

    Document the resolution process for this and what happens if multiple IPs are returned by it.



trunk/include/asterisk/http_websocket.h
<https://reviewboard.asterisk.org/r/3541/#comment21800>

    It would be useful to return why it failed and not just that it did.



trunk/include/asterisk/http_websocket.h
<https://reviewboard.asterisk.org/r/3541/#comment21789>

    These are not client specific. They are session specific.



trunk/main/http.c
<https://reviewboard.asterisk.org/r/3541/#comment21801>

    What happens if this fails? status_code wouldn't get set and would point to silliness



trunk/res/res_http_websocket.c
<https://reviewboard.asterisk.org/r/3541/#comment21802>

    You can undo the protocol changes since the client usage is gone.



trunk/res/res_http_websocket.c
<https://reviewboard.asterisk.org/r/3541/#comment21804>

    For error messages relating to the outgoing connection attempt add additional information so if multiple are going on it is easy to determine which has had an error occur.



trunk/tests/test_websocket_client.c
<https://reviewboard.asterisk.org/r/3541/#comment21787>

    You are not my brother. My brother is named Matthew.


- Joshua Colp


On May 15, 2014, 6:10 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3541/
> -----------------------------------------------------------
> 
> (Updated May 15, 2014, 6:10 p.m.)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Bugs: ASTERISK-23742
>     https://issues.asterisk.org/jira/browse/ASTERISK-23742
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Add client websocket capabilities to Asterisk.
> 
> 
> Diffs
> -----
> 
>   trunk/tests/test_websocket_client.c PRE-CREATION 
>   trunk/res/res_http_websocket.exports.in 413541 
>   trunk/res/res_http_websocket.c 413541 
>   trunk/main/http.c 413541 
>   trunk/include/asterisk/http_websocket.h 413541 
>   trunk/include/asterisk/http.h 413541 
> 
> Diff: https://reviewboard.asterisk.org/r/3541/diff/
> 
> 
> Testing
> -------
> 
> Created some unit tests.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140520/6c505878/attachment-0001.html>