[asterisk-dev] [Code Review] 3541: res_http_websocket: Create a websocket client

[Joshua Colp]

> On May 20, 2014, 10:55 a.m., Joshua Colp wrote:
> > trunk/include/asterisk/http_websocket.h, line 259
> > <https://reviewboard.asterisk.org/r/3541/diff/1/?file=58458#file58458line259>
> >
> >     It would be useful to return why it failed and not just that it did.
> 
> Kevin Harwell wrote:
>     I don't quite understand.  Are you thinking an error string should be passed in and "filled" on failure?  There are errors currently logged on error conditions

No, like returning an enum. The caller of this may want to know that it failed because it couldn't be resolved, or because the URL was incorrect server side, etc. It then may want to change behavior differently (retry at a longer interval for example).


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3541/#review11903
-----------------------------------------------------------


On May 15, 2014, 6:10 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3541/
> -----------------------------------------------------------
> 
> (Updated May 15, 2014, 6:10 p.m.)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Bugs: ASTERISK-23742
>     https://issues.asterisk.org/jira/browse/ASTERISK-23742
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Add client websocket capabilities to Asterisk.
> 
> 
> Diffs
> -----
> 
>   trunk/tests/test_websocket_client.c PRE-CREATION 
>   trunk/res/res_http_websocket.exports.in 413541 
>   trunk/res/res_http_websocket.c 413541 
>   trunk/main/http.c 413541 
>   trunk/include/asterisk/http_websocket.h 413541 
>   trunk/include/asterisk/http.h 413541 
> 
> Diff: https://reviewboard.asterisk.org/r/3541/diff/
> 
> 
> Testing
> -------
> 
> Created some unit tests.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140521/c6680e44/attachment-0001.html>