[asterisk-dev] [Code Review] 3649: Bridging: Allow channels to define additional bridging hooks

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3649/
-----------------------------------------------------------

(Updated June 24, 2014, 1:06 p.m.)


Review request for Asterisk Developers and rmudgett.


Changes
-------

Address issues from Matt, Richard, and Mark.

* Properly wrap and add interval hooks during features merge
* Update documentation
* Add unit tests for interval and DTMF hooks


Bugs: AFS-78
    https://issues.asterisk.org/jira/browse/AFS-78


Repository: Asterisk


Description
-------

This patch allows the current owner of a channel to define various feature hooks to be made available once the channel has entered a bridge.

Currently, it is only possible to attach these hooks by calling ast_bridge_join or as_bridge_impart directly.


Diffs (updated)
-----

  trunk/tests/test_channel_datastore_features.c PRE-CREATION 
  trunk/main/bridge_channel.c 416731 
  trunk/main/bridge.c 416736 
  trunk/include/asterisk/bridge_features.h 416731 
  trunk/include/asterisk/bridge_channel.h 416731 

Diff: https://reviewboard.asterisk.org/r/3649/diff/


Testing
-------

Ensured that DTMF hooks could be attached to the channel via this mechanism and that they became available and were executable once the channel entered a bridge via Dial().


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140624/3cf6a96e/attachment.html>