[asterisk-dev] [Code Review] 3649: Bridging: Allow channels to define additional bridging hooks

[opticron]

> On June 19, 2014, 8:27 p.m., rmudgett wrote:
> > trunk/main/bridge.c, line 3356
> > <https://reviewboard.asterisk.org/r/3649/diff/1/?file=59856#file59856line3356>
> >
> >     Is it kosher to access the .flags member directly and not through an API call?  There doesn't seem to be a call to get the current flags.  Nor is there a merge flags call.  Maybe one needs to be created.

I see that it is accessed directly in app_mixmonitor, main/pbx.c, and res_snmp. I see no documentation stating that members of ast_flags are off-limits.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3649/#review12246
-----------------------------------------------------------


On June 19, 2014, 10:36 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3649/
> -----------------------------------------------------------
> 
> (Updated June 19, 2014, 10:36 a.m.)
> 
> 
> Review request for Asterisk Developers and rmudgett.
> 
> 
> Bugs: AFS-78
>     https://issues.asterisk.org/jira/browse/AFS-78
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch allows the current owner of a channel to define various feature hooks to be made available once the channel has entered a bridge.
> 
> Currently, it is only possible to attach these hooks by calling ast_bridge_join or as_bridge_impart directly.
> 
> 
> Diffs
> -----
> 
>   trunk/main/bridge_channel.c 416438 
>   trunk/main/bridge.c 416438 
>   trunk/include/asterisk/bridge_features.h 416438 
>   trunk/include/asterisk/bridge_channel.h 416438 
> 
> Diff: https://reviewboard.asterisk.org/r/3649/diff/
> 
> 
> Testing
> -------
> 
> Ensured that DTMF hooks could be attached to the channel via this mechanism and that they became available and were executable once the channel entered a bridge via Dial().
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140620/988fd2f8/attachment.html>