[asterisk-dev] [Code Review] 3649: Bridging: Allow channels to define additional bridging hooks

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3649/#review12246
-----------------------------------------------------------



trunk/main/bridge.c
<https://reviewboard.asterisk.org/r/3649/#comment22339>

    This isn't going to work because interval hook objects change as time passes and they have a sequence number that must be consistent with the features struct.  You have to create a wrapper interval hook and use ast_bridge_interval_hook() to add it to the into features struct.
    
    Though it would be nice to do it in such a way that the wrappers won't accumulate.  As you have this now, there would always be two wrappers when the interval hooks actually get used.  One for merging the hook to the channel datastore.  The second when merging the hook into the active bridge interval heap.



trunk/main/bridge.c
<https://reviewboard.asterisk.org/r/3649/#comment22337>

    It might be best to ignore errors here since we are ignoring similar errors when merging the dtmf_hooks and other_hooks.



trunk/main/bridge.c
<https://reviewboard.asterisk.org/r/3649/#comment22338>

    Is it kosher to access the .flags member directly and not through an API call?  There doesn't seem to be a call to get the current flags.  Nor is there a merge flags call.  Maybe one needs to be created.



trunk/main/bridge_channel.c
<https://reviewboard.asterisk.org/r/3649/#comment22341>

    This merging is more expensive than the following tests so you should do it after the test to see if we're still good to be put into a bridge.



trunk/main/bridge_channel.c
<https://reviewboard.asterisk.org/r/3649/#comment22340>

    This message should be an ast_debug() like the others.


- rmudgett


On June 19, 2014, 10:36 a.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3649/
> -----------------------------------------------------------
> 
> (Updated June 19, 2014, 10:36 a.m.)
> 
> 
> Review request for Asterisk Developers and rmudgett.
> 
> 
> Bugs: AFS-78
>     https://issues.asterisk.org/jira/browse/AFS-78
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch allows the current owner of a channel to define various feature hooks to be made available once the channel has entered a bridge.
> 
> Currently, it is only possible to attach these hooks by calling ast_bridge_join or as_bridge_impart directly.
> 
> 
> Diffs
> -----
> 
>   trunk/main/bridge_channel.c 416438 
>   trunk/main/bridge.c 416438 
>   trunk/include/asterisk/bridge_features.h 416438 
>   trunk/include/asterisk/bridge_channel.h 416438 
> 
> Diff: https://reviewboard.asterisk.org/r/3649/diff/
> 
> 
> Testing
> -------
> 
> Ensured that DTMF hooks could be attached to the channel via this mechanism and that they became available and were executable once the channel entered a bridge via Dial().
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140620/e77e0965/attachment-0001.html>