[asterisk-dev] [Code Review] 3602: media_formats: Update main/config_options and tests/test_config

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3602/#review12131
-----------------------------------------------------------



/team/group/media_formats-reviewed/main/format_cap.c
<https://reviewboard.asterisk.org/r/3602/#comment22147>

    The answer is yes. Changing this code so that it returns if they are not exactly equal would be sufficient. IE: != AST_FORMAT_CMP_EQUAL


- Joshua Colp


On June 10, 2014, 7:10 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3602/
> -----------------------------------------------------------
> 
> (Updated June 10, 2014, 7:10 p.m.)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change fixes main/config_options.c and tests/test_config.c to use the new media framework.
> 
> I'm unsure how to replace the check for ast_format_cap_identical, for now it's commented out.  I welcome suggestions on how to fix this, all uses of ast_format_cap_identical in other files were just removed.
> 
> 
> Diffs
> -----
> 
>   /team/group/media_formats-reviewed/tests/test_config.c 415656 
>   /team/group/media_formats-reviewed/main/format_cap.c 415656 
>   /team/group/media_formats-reviewed/main/config_options.c 415656 
>   /team/group/media_formats-reviewed/include/asterisk/format_cap.h 415656 
>   /team/group/media_formats-reviewed/include/asterisk/config_options.h 415656 
> 
> Diff: https://reviewboard.asterisk.org/r/3602/diff/
> 
> 
> Testing
> -------
> 
> Compiled.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140611/03861fbd/attachment-0001.html>