[asterisk-dev] [Code Review] 3602: media_formats: Update main/config_options and tests/test_config
Kevin Harwell
reviewboard at asterisk.org
Wed Jun 11 13:07:35 CDT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3602/#review12127
-----------------------------------------------------------
/team/group/media_formats-reviewed/main/format_cap.c
<https://reviewboard.asterisk.org/r/3602/#comment22146>
Can format caps contain duplicates? If so this could potential return true for unequal sets (for instance cap1 has a duplicate that is found in cap2).
- Kevin Harwell
On June 10, 2014, 2:10 p.m., Corey Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3602/
> -----------------------------------------------------------
>
> (Updated June 10, 2014, 2:10 p.m.)
>
>
> Review request for Asterisk Developers and Joshua Colp.
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> This change fixes main/config_options.c and tests/test_config.c to use the new media framework.
>
> I'm unsure how to replace the check for ast_format_cap_identical, for now it's commented out. I welcome suggestions on how to fix this, all uses of ast_format_cap_identical in other files were just removed.
>
>
> Diffs
> -----
>
> /team/group/media_formats-reviewed/tests/test_config.c 415656
> /team/group/media_formats-reviewed/main/format_cap.c 415656
> /team/group/media_formats-reviewed/main/config_options.c 415656
> /team/group/media_formats-reviewed/include/asterisk/format_cap.h 415656
> /team/group/media_formats-reviewed/include/asterisk/config_options.h 415656
>
> Diff: https://reviewboard.asterisk.org/r/3602/diff/
>
>
> Testing
> -------
>
> Compiled.
>
>
> Thanks,
>
> Corey Farrell
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140611/adcbb686/attachment-0001.html>
More information about the asterisk-dev
mailing list