[asterisk-dev] [Code Review] 3602: media_formats: Update main/config_options and tests/test_config

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3602/
-----------------------------------------------------------

(Updated June 11, 2014, 8:43 p.m.)


Review request for Asterisk Developers and Joshua Colp.


Changes
-------

Update ast_format_cap_identical to check in both directions.  Previously with cap1 = "ulaw,ulaw,alaw" and cap2 = "ulaw,alaw,gsm" the result would be wrong.  Also switched checked for != AST_FORMAT_CMP_EQUAL instead of == AST_FORMAT_CMP_NOT_EQUAL.


Repository: Asterisk


Description
-------

This change fixes main/config_options.c and tests/test_config.c to use the new media framework.

I'm unsure how to replace the check for ast_format_cap_identical, for now it's commented out.  I welcome suggestions on how to fix this, all uses of ast_format_cap_identical in other files were just removed.


Diffs (updated)
-----

  /team/group/media_formats-reviewed/tests/test_config.c 415747 
  /team/group/media_formats-reviewed/main/format_cap.c 415747 
  /team/group/media_formats-reviewed/main/config_options.c 415747 
  /team/group/media_formats-reviewed/include/asterisk/format_cap.h 415747 
  /team/group/media_formats-reviewed/include/asterisk/config_options.h 415747 

Diff: https://reviewboard.asterisk.org/r/3602/diff/


Testing
-------

Compiled.


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140612/1c3613c4/attachment.html>