[asterisk-dev] [Code Review] 3761: media formats: Prevent crash on unset format

opticron reviewboard at asterisk.org
Sat Jul 12 22:01:28 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3761/
-----------------------------------------------------------

(Updated July 12, 2014, 10:01 p.m.)


Review request for Asterisk Developers, Corey Farrell and Matt Jordan.


Changes
-------

Update to using ast_format_none as the initial value for rtp->lastrxformat, rtp->lasttxformat, and rtp->f.subclass.format.


Repository: Asterisk


Description
-------

This prevents a crash on getting the codec rate for unset formats. This can be validly NULL if the RTP instance has never receieved an audio RTP frame which can occur in off-nominal situations.


Diffs (updated)
-----

  team/group/media_formats-reviewed-trunk/res/res_rtp_asterisk.c 418441 

Diff: https://reviewboard.asterisk.org/r/3761/diff/


Testing
-------


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140713/e2015443/attachment-0001.html>


More information about the asterisk-dev mailing list