[asterisk-dev] [Code Review] 3761: media formats: Prevent crash on unset format

opticron reviewboard at asterisk.org
Sat Jul 12 14:11:16 CDT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3761/
-----------------------------------------------------------

(Updated July 12, 2014, 2:11 p.m.)


Review request for Asterisk Developers, Corey Farrell and Matt Jordan.


Changes
-------

Rework the patch to pull the checks out to where they really need to be.


Repository: Asterisk


Description
-------

This prevents a crash on getting the codec rate for unset formats. This can be validly NULL if the RTP instance has never receieved an audio RTP frame which can occur in off-nominal situations.


Diffs (updated)
-----

  team/group/media_formats-reviewed-trunk/res/res_rtp_asterisk.c 418441 
  team/group/media_formats-reviewed-trunk/main/sounds_index.c 418441 
  team/group/media_formats-reviewed-trunk/main/format.c 418441 
  team/group/media_formats-reviewed-trunk/main/astobj2.c 418441 

Diff: https://reviewboard.asterisk.org/r/3761/diff/


Testing
-------


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140712/0df5719c/attachment-0001.html>


More information about the asterisk-dev mailing list