[asterisk-dev] [Code Review] 3761: media formats: Prevent crash on unset format

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3761/#review12600
-----------------------------------------------------------



team/group/media_formats-reviewed-trunk/res/res_rtp_asterisk.c
<https://reviewboard.asterisk.org/r/3761/#comment22887>

    Since rtp is newly allocated, can we just do rtp->lastrxformat = ao2_bump(ast_format_none);
    
    ao2_replace makes it appear as if these formats might be previously set.


- Corey Farrell


On July 12, 2014, 11:01 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3761/
> -----------------------------------------------------------
> 
> (Updated July 12, 2014, 11:01 p.m.)
> 
> 
> Review request for Asterisk Developers, Corey Farrell and Matt Jordan.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This prevents a crash on getting the codec rate for unset formats. This can be validly NULL if the RTP instance has never receieved an audio RTP frame which can occur in off-nominal situations.
> 
> 
> Diffs
> -----
> 
>   team/group/media_formats-reviewed-trunk/res/res_rtp_asterisk.c 418441 
> 
> Diff: https://reviewboard.asterisk.org/r/3761/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140713/08e8c972/attachment-0001.html>