[asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3155/#review10701
-----------------------------------------------------------


Current code says "You will be placed into the conference." to a marked user when:
1) The marked user is the first to join the conference.  (Transitions from EMPTY to SINGLE_MARKED)
2) There are other users and this is the first marked user to join. (Transitions from SINGLE/INACTIVE/MULTI to MULTI_MARKED)

This patch only changes case 2 above.  It should play the conference begin sound to the conference when the first marked user joins and there are other users present.

Case 1 makes more sense to say "You are the only person in the conference." instead.  conf_handle_only_unmarked() renamed to conf_handle_only_person().

The "You will be placed into the conference." prompt makes more sense to be played to a joining waitmarked or marked user if a marked user is already there.

- rmudgett


On Jan. 24, 2014, 1:05 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3155/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2014, 1:05 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: PQ-1396
>     https://issues.asterisk.org/jira/browse/PQ-1396
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Currently, when the first marked user enters the conference that contains waitmarked users, a prompt is played indicating that the user is being placed into the conference. Unfortunately, this prompt is played to the marked user and not the waitmarked users which is not very helpful.
> 
> This patch changes that behavior to play a prompt stating "The conference will now begin" to the entire conference after adding and unmuting the waitmarked users since the design of confbridge is not conducive to playing a prompt to a subset of users in a conference in an asynchronous manner.
> 
> 
> Diffs
> -----
> 
>   branches/11/configs/confbridge.conf.sample 406292 
>   branches/11/apps/confbridge/include/confbridge.h 406292 
>   branches/11/apps/confbridge/conf_state_multi_marked.c 406292 
>   branches/11/apps/confbridge/conf_config_parser.c 406292 
>   branches/11/apps/app_confbridge.c 406292 
> 
> Diff: https://reviewboard.asterisk.org/r/3155/diff/
> 
> 
> Testing
> -------
> 
> Verified that the prompt is heard by users already in the conference when a marked user enters.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140125/c8493ca3/attachment-0001.html>