[asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3155/#review10690
-----------------------------------------------------------



branches/11/apps/confbridge/conf_state_multi_marked.c
<https://reviewboard.asterisk.org/r/3155/#comment20183>

    The sound can be played back in a couple of situations where it may not be desired.
    
    1) Conference starts empty. The first user that enters is marked. The second user enters (may be marked, waitmarked, or have no affiliation with marks). When the second user enters, the conference will have CONF_SOUND_BEGIN played to them. In this case, since no one was waiting on the marked user, it seems weird to do this. You can get around this by adding the check that was previously here, which is to check if cbu is a marked user.
    
    2) A bunch of non-waitmarked users are in the conference chatting away, and a marked user enters. CONF_SOUND_BEGIN will play when the marked user enters. You could get around this by not playing the sound if there were no waitmarked users in the conference when the marked user entered.


- Mark Michelson


On Jan. 24, 2014, 7:05 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3155/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2014, 7:05 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: PQ-1396
>     https://issues.asterisk.org/jira/browse/PQ-1396
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Currently, when the first marked user enters the conference that contains waitmarked users, a prompt is played indicating that the user is being placed into the conference. Unfortunately, this prompt is played to the marked user and not the waitmarked users which is not very helpful.
> 
> This patch changes that behavior to play a prompt stating "The conference will now begin" to the entire conference after adding and unmuting the waitmarked users since the design of confbridge is not conducive to playing a prompt to a subset of users in a conference in an asynchronous manner.
> 
> 
> Diffs
> -----
> 
>   branches/11/configs/confbridge.conf.sample 406292 
>   branches/11/apps/confbridge/include/confbridge.h 406292 
>   branches/11/apps/confbridge/conf_state_multi_marked.c 406292 
>   branches/11/apps/confbridge/conf_config_parser.c 406292 
>   branches/11/apps/app_confbridge.c 406292 
> 
> Diff: https://reviewboard.asterisk.org/r/3155/diff/
> 
> 
> Testing
> -------
> 
> Verified that the prompt is heard by users already in the conference when a marked user enters.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140124/d4ea2779/attachment-0001.html>