[asterisk-dev] [Code Review] 3155: ConfBridge: Correct prompt playback target

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3155/#review10708
-----------------------------------------------------------


If you haven't already, run the ConfBridge tests in the Asterisk Test Suite and verify that all tests pass with your changes. I suspect the marked users test may fail, as it checks for certain sound file prompts being played.

You may also want to update the appropriate tests to verify that the correct sound file is played back with your changes.

- Matt Jordan


On Jan. 24, 2014, 1:05 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3155/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2014, 1:05 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: PQ-1396
>     https://issues.asterisk.org/jira/browse/PQ-1396
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Currently, when the first marked user enters the conference that contains waitmarked users, a prompt is played indicating that the user is being placed into the conference. Unfortunately, this prompt is played to the marked user and not the waitmarked users which is not very helpful.
> 
> This patch changes that behavior to play a prompt stating "The conference will now begin" to the entire conference after adding and unmuting the waitmarked users since the design of confbridge is not conducive to playing a prompt to a subset of users in a conference in an asynchronous manner.
> 
> 
> Diffs
> -----
> 
>   branches/11/configs/confbridge.conf.sample 406292 
>   branches/11/apps/confbridge/include/confbridge.h 406292 
>   branches/11/apps/confbridge/conf_state_multi_marked.c 406292 
>   branches/11/apps/confbridge/conf_config_parser.c 406292 
>   branches/11/apps/app_confbridge.c 406292 
> 
> Diff: https://reviewboard.asterisk.org/r/3155/diff/
> 
> 
> Testing
> -------
> 
> Verified that the prompt is heard by users already in the conference when a marked user enters.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140128/e598db78/attachment.html>