[asterisk-dev] [Code Review] 4243: ari: Add the ability to specify a linkedId when originating calls.

[Scott Griepentrog]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4243/#review13908
-----------------------------------------------------------


I'm concerned that the use of ast_channel_internal_set_fake_ids() - which doesn't set the time fields of ast_channel_id - could result in possibly incorrect behavior during propagation.  Granted, the supplied linkedid should always win over the originated channel, but then later that originated channel should win or not win in propagation based on the channel that the linkedid was originally copied from (whereas an unset time value would result in always being the oldest channel).  At the very least, the time values need to be initalized, but preferably the entire ast_channel_id struct would be copied from the channel you want linkedid to come from.

- Scott Griepentrog


On Dec. 5, 2014, 2:28 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4243/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2014, 2:28 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24552
>     https://issues.asterisk.org/jira/browse/ASTERISK-24552
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Currently when originating a call using ARI there is no way to specify an association of who is triggering the outbound dial. This is normally visible through the LinkedID. To allow this association to be present I've added the ability to set LinkedID (optionally) when originating the call.
> 
> 
> Diffs
> -----
> 
>   /branches/13/rest-api/api-docs/channels.json 429025 
>   /branches/13/res/res_ari_channels.c 429025 
>   /branches/13/res/ari/resource_channels.c 429025 
>   /branches/13/res/ari/resource_channels.h 429025 
> 
> Diff: https://reviewboard.asterisk.org/r/4243/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing ARI origination tests and confirmed they still pass.
> Performed calls manually and examined the resulting channels and CEL log to ensure they contain the provided linked ID.
> Ran new test to confirm that the resulting CEL events contain the provided linked ID.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141205/da0c9788/attachment.html>