[asterisk-dev] [Code Review] 4243: ari: Add the ability to specify a linkedId when originating calls.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4243/#review13907
-----------------------------------------------------------


Since channel unique ids can be assigned by the user, they now have an internal timestamp to allow linked id propagation of the oldest channel unique id.  How is this accounted for in the code when passing in the linked id to use?  Is the passed in linked id supposed to be a referring channel that the code can get a linked id from?


/branches/13/res/ari/resource_channels.c
<https://reviewboard.asterisk.org/r/4243/#comment24417>

    This channel cannot be made to /continue in dialplan when the Stasis application exits.


- rmudgett


On Dec. 5, 2014, 2:28 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4243/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2014, 2:28 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24552
>     https://issues.asterisk.org/jira/browse/ASTERISK-24552
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Currently when originating a call using ARI there is no way to specify an association of who is triggering the outbound dial. This is normally visible through the LinkedID. To allow this association to be present I've added the ability to set LinkedID (optionally) when originating the call.
> 
> 
> Diffs
> -----
> 
>   /branches/13/rest-api/api-docs/channels.json 429025 
>   /branches/13/res/res_ari_channels.c 429025 
>   /branches/13/res/ari/resource_channels.c 429025 
>   /branches/13/res/ari/resource_channels.h 429025 
> 
> Diff: https://reviewboard.asterisk.org/r/4243/diff/
> 
> 
> Testing
> -------
> 
> Ran all existing ARI origination tests and confirmed they still pass.
> Performed calls manually and examined the resulting channels and CEL log to ensure they contain the provided linked ID.
> Ran new test to confirm that the resulting CEL events contain the provided linked ID.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141205/01d9841a/attachment.html>