<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4243/">https://reviewboard.asterisk.org/r/4243/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm concerned that the use of ast_channel_internal_set_fake_ids() - which doesn't set the time fields of ast_channel_id - could result in possibly incorrect behavior during propagation. Granted, the supplied linkedid should always win over the originated channel, but then later that originated channel should win or not win in propagation based on the channel that the linkedid was originally copied from (whereas an unset time value would result in always being the oldest channel). At the very least, the time values need to be initalized, but preferably the entire ast_channel_id struct would be copied from the channel you want linkedid to come from.</pre>
<br />
<p>- Scott Griepentrog</p>
<br />
<p>On December 5th, 2014, 2:28 p.m. CST, Joshua Colp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>
<p style="color: grey;"><i>Updated Dec. 5, 2014, 2:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24552">ASTERISK-24552</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently when originating a call using ARI there is no way to specify an association of who is triggering the outbound dial. This is normally visible through the LinkedID. To allow this association to be present I've added the ability to set LinkedID (optionally) when originating the call.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran all existing ARI origination tests and confirmed they still pass.
Performed calls manually and examined the resulting channels and CEL log to ensure they contain the provided linked ID.
Ran new test to confirm that the resulting CEL events contain the provided linked ID.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/13/rest-api/api-docs/channels.json <span style="color: grey">(429025)</span></li>
<li>/branches/13/res/res_ari_channels.c <span style="color: grey">(429025)</span></li>
<li>/branches/13/res/ari/resource_channels.c <span style="color: grey">(429025)</span></li>
<li>/branches/13/res/ari/resource_channels.h <span style="color: grey">(429025)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4243/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>